Skip to content

ASoC: SOF: ipc4-pcm: new spcm_dbg_ratelimited() wrapper and use it for inaccurate delay print #5538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ujfalusi merged 2 commits into from
Oct 1, 2025
Merged

ASoC: SOF: ipc4-pcm: new spcm_dbg_ratelimited() wrapper and use it for inaccurate delay print #5538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f51cdc0
ASoC: SOF: sof-audio: add dev_dbg_ratelimited wrapper
ujfalusi Sep 18, 2025
f2aae3b
fixup! ASoC: SOF: ipc4-pcm: do not report invalid delay values
ujfalusi Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sound/soc/sof/ipc4-pcm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,8 +1269,9 @@ static int sof_ipc4_pcm_pointer(struct snd_soc_component *component,
time_info->delay = head_cnt - tail_cnt;

if (time_info->delay > DELAY_MAX) {
dev_dbg_ratelimited(sdev->dev,
"inaccurate delay, host %llu dai_cnt %llu", host_cnt, dai_cnt);
spcm_dbg_ratelimited(spcm, substream->stream,
"inaccurate delay, host %llu dai_cnt %llu",
host_cnt, dai_cnt);
time_info->delay = 0;
}

Expand Down
5 changes: 5 additions & 0 deletions sound/soc/sof/sof-audio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,11 @@ void snd_sof_pcm_init_elapsed_work(struct work_struct *work);
(__spcm)->pcm.pcm_id, (__spcm)->pcm.pcm_name, __dir, \
Copy link
Collaborator

@kv2019i kv2019i Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/reate/rate/

##__VA_ARGS__)

#define spcm_dbg_ratelimited(__spcm, __dir, __fmt, ...) \
dev_dbg_ratelimited((__spcm)->scomp->dev, "pcm%u (%s), dir %d: " __fmt, \
(__spcm)->pcm.pcm_id, (__spcm)->pcm.pcm_name, __dir, \
##__VA_ARGS__)

#define spcm_err(__spcm, __dir, __fmt, ...) \
dev_err((__spcm)->scomp->dev, "%s: pcm%u (%s), dir %d: " __fmt, \
__func__, (__spcm)->pcm.pcm_id, (__spcm)->pcm.pcm_name, __dir, \
Expand Down
Loading