Revert display audio parallel suspend/resume (no device_link for SOF) support#5478
Merged
ujfalusi merged 4 commits intothesofproject:topic/sof-devfrom Jul 3, 2025
Conversation
…k creation" This reverts commit d431348. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
…or display audio" This reverts commit 0aeb011. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
… pointer" This reverts commit aa07f95. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
…io component" This reverts commit 7b8a0b7. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
bardliao
approved these changes
Jul 2, 2025
kv2019i
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
while on surface things looked fine, thanks to insights from @ideak it is proven that we still have sequencing issues:
on resume the intel_audio_component_get_power()/intel_audio_component_put_power() is toggled before i915_drm_resume(), which must not happen.
Reverting the series for now (although we could just revert the last patch to enable this for SOF, but let's not have the code at all)