drm/xe: Update XE GuC firmware version for PTL#5455
drm/xe: Update XE GuC firmware version for PTL#5455bardliao merged 5 commits intothesofproject:topic/sof-devfrom
Conversation
This reverts commit 9e65e00. The commit conflicts to the new kernel. And the GuC firmware version has been updated. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
The `entries` variable is used to loop through the array - it's supposed to be const, but not static. Reviewed-by: John Harrison <John.C.Harrison@Intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250307-xe-per-gt-fw-v1-1-459574d76400@intel.com Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
The different GTs on a device can be very different. Right now for all platforms the same firmware is loaded in each GT, however future platforms may benefit from loading a different file depending on the GT type. Based on previous patch by John Harrison <John.C.Harrison@Intel.com>. Reviewed-by: John Harrison <John.C.Harrison@Intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250307-xe-per-gt-fw-v1-2-459574d76400@intel.com Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
A new workaround requires a newer GuC version. So, recommend that users install it. Signed-off-by: John Harrison <John.C.Harrison@Intel.com> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Link: https://lore.kernel.org/r/20250403185619.1555853-6-John.C.Harrison@Intel.com Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
bardliao
requested review from
dbaluta,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
|
v2: |
but should not the DUTs to be updated to use the recommended firmware? |
and basically we stay at the same version as before this PR, iow this is a NOP? |
Need @kv2019i's comment.
Yes, this is a NOP. The main reason is that the previous commit conflicts to the new kernel. |
Ok, but I have no idea where should we get the PTL guc firmware. I can't find it from https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/xe. |
|
CI shows below error. |
drivers/gpu/drm/xe/xe_uc_fw.c
Outdated
| #define XE_GT_TYPE_ANY XE_GT_TYPE_UNINITIALIZED | ||
|
|
||
| #define XE_GUC_FIRMWARE_DEFS(fw_def, mmp_ver, major_ver) \ | ||
| fw_def(PANTHERLAKE, GT_TYPE_ANY, major_ver(xe, guc, ptl, 70, 44, 1)) \ |
There was a problem hiding this comment.
@bardliao This is not correct. Please cherry-pick following from upstream instead:
commit 738538d0edb88e0c2f758dfc299146087f34826e
Author: Clint Taylor <clinton.a.taylor@intel.com>
Date: Thu Apr 3 11:56:17 2025 -0700
drm/xe/ptl: Add GuC firmware definition
This is available at least in drm-tip/drm-tip.
Define the GuC firmware to load on the platform. Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com> Reviewed-by: John Harrison <John.C.Harrison@Intel.com> Acked-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250403185619.1555853-8-John.C.Harrison@Intel.com Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
|
SOFCI TEST |
5 participants
Fix the conflict and bump the recommended GuC version.