ASoC: Intel: add SDCA Amp feedback fragment topology support#5448
ASoC: Intel: add SDCA Amp feedback fragment topology support#5448bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
|
Hi, I tried testing this. Whilst it works in some instances, in others there are issue. It seems to always create the same number of feedback channels: 4. Testing with 2 amps and 4 amps, it seems to work, but testing with 6 amps breaks it. |
| dai_link->num_cpus); | ||
| /* Remove the AMP topology, just use the Amp feedback topology */ | ||
| if (tplg_mask & BIT(TPLG_DEVICE_SDCA_AMP)) { | ||
| tplg_mask &= ~BIT(TPLG_DEVICE_SDCA_AMP); |
There was a problem hiding this comment.
@bardliao is this correct? Shouldn't we be replacing the entry in the tplg_files array with the amp feedback topology instead of simply updating the count and mask?
There was a problem hiding this comment.
@ranj063 You are right. Currently it works by accident. It works just because the amp feedback link is always right after the amp playback link. I will fix it.
|
Thanks @stefdb for the feedback. Let me think about how to get the channel number, thanks. |
| if (!tplg_dev_name) | ||
| return -ENOMEM; | ||
|
|
||
| /* No need to add tplg file to the tplg_files list */ |
There was a problem hiding this comment.
but dont you need to update the mask ?
There was a problem hiding this comment.
but dont you need to update the mask ?
Indeed, fixed.
|
Convert it to draft as we need to handle the feedback channel number. |
Use the topology with feedback PCM if the SDCA smart amp capture dai link is created. The commit makes an assumption that the smart amp playback dai link is always created if the smart amp capture dai link is present. That is a reasonable assumption because it makes no sense that a feedback work without playback. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
|
@stefdb @rfvirgil @simontrimmer @charleskeepax Do you have any idea that we can get the feedback channel number at this stage? Can I assume that a cs35l56 amp will need 2 channels? Actually, I am thinking if having the feedback PCM device is not common (currently for developing only?), we can just not set |
4 participants
Use the topology with feedback PCM if the SDCA smart amp capture dai link is created. The commit makes an assumption that the smart amp playback dai link is always created if the smart amp capture dai link is present. That is a reasonable assumption because it makes no sense that a feedback work without playback.