fixup! ASoC: SOF: sof-client-probes-ipc4: Implement ipc4_probes_point…#5447
Merged
ujfalusi merged 1 commit intothesofproject:topic/sof-devfrom Jun 9, 2025
Merged
Conversation
…s_info sof client drivers must not access sdev directly. remove the sof-priv.h include as well Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
bardliao
approved these changes
Jun 9, 2025
jsarha
approved these changes
Jun 9, 2025
jsarha
left a comment
jsarha
left a comment
There was a problem hiding this comment.
Looks good to me. Should have removed my self the "sof-priv.h" and added sof_client_get_ipc_max_payload_size(), but its so easy to forget that sof-clients are not supposed to access sof-core internals.
kv2019i
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s_info
sof client drivers must not access sdev directly.
remove the sof-priv.h include as well
Replaces #5446, which got closed by accident