Skip to content

[DNM][WIP] HDA/SOF/i915: Do not create device link for HDMI audio whe…#5433

Closed
ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
ujfalusi:peter/sof/pr/no-device-link-for-hdmi-dnm
Closed

[DNM][WIP] HDA/SOF/i915: Do not create device link for HDMI audio whe…#5433
ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
ujfalusi:peter/sof/pr/no-device-link-for-hdmi-dnm

Conversation

@ujfalusi
Copy link
Copy Markdown
Collaborator

…n SOF is used

There seams to be no reason to create the device link between display and audio when it is used with SOF.

…n SOF is used

There seams to be no reason to create the device link between display and
audio when it is used with SOF.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
@kv2019i
Copy link
Copy Markdown
Collaborator

kv2019i commented May 30, 2025

Dug up the old commit from Imre that added the link (2018, predates my time in Intel audio):
commit aef9f33

The commit message doesn't go into details w.r.t. the dependencies on audio side. We clearly have cases (like Haswell, discrete GPU cases) where the link is needed, but the needs for cases like SOF (where controller is on its own PCI device), are less well documented.

My primary concern is does this resurface bugs like: commit e3c714b (see lot of discussion around 2020 #1764) bugs like

I think most of these relate to setting the HDA bus parameters (T-mode and clock-pull settings). In large amount of devices, the hardware defaults are correct (= match the settings BIOS will set for audio side), but especially in TGL/ADL products, we had cases where this was not the case and we had HDA VERBs fail to the display code. Spec-wise this is not clearcut, and in theory shoudl work, but in practise we did get bug reports unless we used a strict order and ensured a get_power() call before HDA controller reset.

But, but, this PR does NOT remove the get_power() calls in SOF resume though, so in theory this should still work. I'm not 100% sure what happens when audio calls get_power() when i915 is not fulled resumed. Will the call block until display is powered up?

@ujfalusi
Copy link
Copy Markdown
Collaborator Author

replaced by: #5458

@ujfalusi ujfalusi closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants