fixup! ASoC: SOF: add disable_function_topology module parameter#5405
Merged
ujfalusi merged 1 commit intothesofproject:topic/sof-devfrom May 6, 2025
Merged
Conversation
To fix the checkpatch error below. ERROR: do not initialise statics to false +static bool disable_function_topology = false; total: 1 errors, 0 warnings, 0 checks, 20 lines checked Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a checkpatch error by removing an explicit initializer for a static boolean variable in topology.c, relying on the default zero initialization provided by C.
- Removed explicit initialization of disable_function_topology to false
- Updated module parameter declaration accordingly
dbaluta
approved these changes
May 6, 2025
ujfalusi
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the checkpatch error below.
ERROR: do not initialise statics to false
+static bool disable_function_topology = false;
total: 1 errors, 0 warnings, 0 checks, 20 lines checked