Audio support for WCL#5397
Conversation
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
lyakh,
plbossart and
ranj063
as code owners
sound/soc/sof/intel/pci-ptl.c
Outdated
| .default_fw_filename = { | ||
| [SOF_IPC_TYPE_4] = "sof-wcl.ri", | ||
| }, | ||
| .nocodec_tplg_filename = "sof-wcl-nocodec.tplg", |
There was a problem hiding this comment.
How should this be?
we use the snd_soc_acpi_intel_ptl_machines and snd_soc_acpi_intel_ptl_sdw_machines but the nocodec is using sof-wcl-
Should we duplicate the ptl mach with s/ptl/wcl applied or change the nocodec to sof-ptl as well?
WCL is in essence PTL with reduced number of cores.
There was a problem hiding this comment.
I think in general WCL tplgs should be separate. Let's have nocodec separate as well. sof-ptl-nocodec.tplg only uses cores 0+1+2 now, but if this is changed at some point, it'll break WCL machines using this (albeit this is for R&D but still).
UPDATE: I'll change my mind, ptl-nocodec is ok.
ujfalusi
force-pushed
the
peter/sof/pr/wcl-support-01
branch
from
171274e to
5f1bb7f
Compare
Add PCI id for Wildcat Lake audio. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Clone PTL and adjust the number of cores from 5 to 3. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
WCL uses the same receipt as PTL and PTL-H Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
One more PCI ID. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
|
Changes since v1:
|
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
After some back and forth, I'm now ok with this in its current form.
| .power_down_dsp = mtl_power_down_dsp, | ||
| .disable_interrupts = lnl_dsp_disable_interrupts, | ||
| .hw_ip_version = SOF_INTEL_ACE_3_0, | ||
| }; |
There was a problem hiding this comment.
@ujfalusi this patch is good for now but yuou know what I'm thinking. We should abstract some of the fields here that are largely unmodified gen to gen. something to consider doing in the future.
5 participants
PCI ID and support for Wildcat Lake audio