ASoC: SOF: imx8m: Use reset controller API to control the DSP#5394
Merged
dbaluta merged 1 commit intothesofproject:topic/sof-devfrom May 5, 2025
dbaluta:add_reset_api
Merged
ASoC: SOF: imx8m: Use reset controller API to control the DSP#5394dbaluta merged 1 commit intothesofproject:topic/sof-devfrom dbaluta:add_reset_api
dbaluta merged 1 commit intothesofproject:topic/sof-devfrom
dbaluta:add_reset_api
Conversation
dbaluta
requested review from
bardliao,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the DSP reset flow on i.MX8MP by switching from direct regmap bit manipulations to using the reset controller API for better probe ordering and abstraction.
- Added the reset controller header and associated API calls
- Replaced regmap_update_bits with reset_control_assert and reset_control_deassert
- Updated the probe function to acquire the reset control resource
sound/soc/sof/imx/imx8.c
Outdated
Comment on lines
172
to
173
| "failed to get dsp runstall reset controll\n"); | ||
|
|
There was a problem hiding this comment.
Typo in error message: 'controll' should be changed to 'control'.
Suggested change
| "failed to get dsp runstall reset controll\n"); | |
| "failed to get dsp runstall reset control\n"); |
DSP on i.MX8MP doesn't have a direct reset line so according to hardware design team in order to handle assert/deassert/reset functionality we need to use a combination of control bits from two modules. Audio block control module for Run/Stall control of the DSP and DAP module in order to do software reset. In a first step, for i.MX8MP we are switching on using the reset controller API to handle the DSP Run/Stall bits i.MX8MP. This comes with the advantage of offering a better probe ordering and a more natural way of abstracting the Audio block control bits. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
LaurentiuM1234
approved these changes
Apr 28, 2025
LaurentiuM1234
left a comment
LaurentiuM1234
left a comment
There was a problem hiding this comment.
Tested-by: Laurentiu Mihalcea laurentiu.mihalcea@nxp.com
bardliao
approved these changes
Apr 29, 2025
Collaborator
Author
|
SOFCI TEST |
ujfalusi
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSP on i.MX8MP doesn't have a direct reset line so according to hardware design team in order to handle assert/deassert/reset functionality we need to use a combination of control bits from two modules. Audio block control module for Run/Stall control of the DSP and DAP module in order to do software reset.
In a first step, for i.MX8MP we are switching on using the reset controller API to handle the DSP Run/Stall bits i.MX8MP. This comes with the advantage of offering a better probe ordering and a more natural way of abstracting the Audio block control bits.