Skip to content

ASoC: rt1320: set wake_capable = 0 explicitly #5337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ranj063 merged 1 commit into from
Mar 3, 2025
Merged

ASoC: rt1320: set wake_capable = 0 explicitly #5337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sound/soc/codecs/rt1320-sdw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,9 @@ static int rt1320_read_prop(struct sdw_slave *slave)
/* set the timeout values */
prop->clk_stop_timeout = 64;

/* BIOS may set wake_capable. Make sure it is 0 as wake events are disabled. */
prop->wake_capable = 0;
Copy link
Collaborator

@ujfalusi ujfalusi Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wake_capable_list[] is intel specific (drivers/soundwire/intel_auxdevice.c), the codec driver is not.
I'm not sure how other OSs can handle if the rt1320 is marked by BIOS as wake capable and why we cannot.

The rt1320 can be used on devices sporting other vendor's SoC..


return 0;
}

Expand Down
Loading