ASoC: Intel: soc-acpi-intel-lnl-match: add cs42l43 6x cs35l56 support#5331
Merged
bardliao merged 2 commits intothesofproject:topic/sof-devfrom Feb 26, 2025
Merged
ASoC: Intel: soc-acpi-intel-lnl-match: add cs42l43 6x cs35l56 support#5331bardliao merged 2 commits intothesofproject:topic/sof-devfrom
bardliao merged 2 commits intothesofproject:topic/sof-devfrom
Conversation
Collaborator
Author
|
@simontrimmer @rfvirgil I vaguely remember that you have a naming rule for acpi adr devices but I can't find it. Could you correct me if |
lgirdwood
previously approved these changes
Feb 18, 2025
Collaborator
|
Hi @bardliao I think the naming convention recollection you may be thinking of was this one:
Will have a look at the naming in a mo |
| }, | ||
| }; | ||
|
|
||
| static const struct snd_soc_acpi_endpoint cs42l43_amp_spkagg_ndpoints[] = { |
Collaborator
There was a problem hiding this comment.
cs42l43_amp_spkagg_ndpoints -> cs42l43_amp_spkagg_endpoints ?
This add a match for cs42l43 on sdw link 2, 3 cs35l56 on sdw link 1 and 3. All speakers are aggregated. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This add a match for cs42l43 on sdw link 2, 3 cs35l56 on sdw link 1 and 3. All speakers are aggregated. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
8c0fc01 to
990849f
Compare
lgirdwood
approved these changes
Feb 19, 2025
Collaborator
Author
|
@simontrimmer Does it look good now? |
Collaborator
|
Hi @bardliao I don't have one of those boards but yes looks good to me! |
simontrimmer
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add a match for cs42l43 on sdw link 2, 3 cs35l56 on sdw link 1 and
3. All speakers are aggregated.