Skip to content

Revert "ASoC: SOF: Intel: hda: Add module parameter to disable displa…#5322

Merged
ranj063 merged 2 commits intothesofproject:topic/sof-devfrom
ujfalusi:peter/sof/pr/revert-sof-gpu-bind-01
Feb 14, 2025
Merged

Revert "ASoC: SOF: Intel: hda: Add module parameter to disable displa…#5322
ranj063 merged 2 commits intothesofproject:topic/sof-devfrom
ujfalusi:peter/sof/pr/revert-sof-gpu-bind-01

Conversation

@ujfalusi
Copy link
Collaborator

@ujfalusi ujfalusi commented Feb 6, 2025

…y audio bind"

This reverts commit 9170f2c.

We should be using the
options snd_hda_core gpu_bind=0

to disable GPU binding, this patch is not needed.

ranj063
ranj063 previously approved these changes Feb 6, 2025
Copy link
Collaborator

@ranj063 ranj063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the original commit already upstream?

@ujfalusi
Copy link
Collaborator Author

ujfalusi commented Feb 7, 2025

is the original commit already upstream?

No, I was about to prepare it when I have noticed that the snd_hdac_i915_bind() is only exported in SOF by a commit:
[NOT FOR UPSTREAM] ALSA: hdac_i915: add helper to disable GPU bind - which can be dropped as well.

…y audio bind"

This reverts commit 9170f2c.

We should be using the
options snd_hda_core gpu_bind=0

to disable GPU binding, this patch is not needed.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
… bind"

This reverts commit 603c3ed.

This is no longer needed as we can use module option:
options snd_hda_core gpu_bind=0

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
@ujfalusi
Copy link
Collaborator Author

ujfalusi commented Feb 7, 2025

Changes since v1:

  • revert also [NOT FOR UPSTREAM] ALSA: hdac_i915: add helper to disable GPU bind patch as it is no longer needed

@ujfalusi
Copy link
Collaborator Author

ujfalusi commented Feb 7, 2025

SOFCI TEST

@ranj063 ranj063 merged commit 87312c5 into thesofproject:topic/sof-dev Feb 14, 2025
9 of 14 checks passed
@ujfalusi ujfalusi deleted the peter/sof/pr/revert-sof-gpu-bind-01 branch May 19, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants