Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #1

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Initial implementation #1

merged 7 commits into from
Jul 26, 2024

Conversation

pcrock-thmdo
Copy link
Contributor

@pcrock-thmdo pcrock-thmdo commented Jul 24, 2024

https://thermondo.atlassian.net/browse/TD-1255

Very similar to thermondo/heroku-buildpack-caddy#1

Configuration for the buildpack is identical to the way we configure our sigsci-container.

@pcrock-thmdo pcrock-thmdo self-assigned this Jul 24, 2024
@pcrock-thmdo pcrock-thmdo marked this pull request as ready for review July 24, 2024 13:05
@pcrock-thmdo pcrock-thmdo requested a review from a team July 24, 2024 13:06
Copy link

@sbresin sbresin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@pcrock-thmdo pcrock-thmdo merged commit 1c15cbd into main Jul 26, 2024
1 check passed
@pcrock-thmdo pcrock-thmdo deleted the initial-implementation branch July 26, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants