Improve components interface

thephpleague · Sep 22, 2015 · 5a6e225 · 5a6e225
1 parent 59a0298
commit 5a6e225
Show file tree

Hide file tree

Showing 10 changed files with 46 additions and 13 deletions.
diff --git a/src/Components/Fragment.php b/src/Components/Fragment.php
@@ -45,7 +45,7 @@ public function getUriComponent()
     {
         $component = $this->__toString();
         if (!empty($component)) {
-            $component = '#'.$component;
+            $component = FragmentInterface::DELIMITER.$component;
         }
 
         return $component;

diff --git a/src/Components/Port.php b/src/Components/Port.php
@@ -51,7 +51,7 @@ protected function validate($port)
      */
     public function getUriComponent()
     {
-        return null === $this->data ? '' : ':'.$this->data;
+        return null === $this->data ? '' : PortInterface::DELIMITER.$this->data;
     }
 
     /**

diff --git a/src/Components/Query.php b/src/Components/Query.php
@@ -38,13 +38,6 @@ class Query implements QueryInterface
      */
     protected static $separator = '&';
 
-    /**
-     * string delimiter
-     *
-     * @var string
-     */
-    protected static $delimiter = '?';
-
     /**
      * a new instance
      *
@@ -125,7 +118,7 @@ public function getUriComponent()
     {
         $query = $this->__toString();
         if (!empty($query)) {
-            $query = static::$delimiter.$query;
+            $query = QueryInterface::DELIMITER.$query;
         }
 
         return $query;

diff --git a/src/Components/Scheme.php b/src/Components/Scheme.php
@@ -47,7 +47,7 @@ public function getUriComponent()
     {
         $component = $this->__toString();
         if (!empty($component)) {
-            $component .= ':';
+            $component .= SchemeInterface::DELIMITER;
         }
 
         return $component;

diff --git a/src/Components/UserInfo.php b/src/Components/UserInfo.php
@@ -84,7 +84,7 @@ public function __toString()
 
         $pass = $this->pass->__toString();
         if (!empty($pass)) {
-            $userInfo .= ':'.$pass;
+            $userInfo .= UserInfoInterface::SEPARATOR.$pass;
         }
 
         return $userInfo;
@@ -97,7 +97,7 @@ public function getUriComponent()
     {
         $component = $this->__toString();
         if (!empty($component)) {
-            $component .= '@';
+            $component .= UserInfoInterface::DELIMITER;
         }
 
         return $component;

diff --git a/src/Interfaces/Fragment.php b/src/Interfaces/Fragment.php
@@ -26,4 +26,10 @@
  */
 interface Fragment extends Component
 {
+    /**
+     * URI component delimiter.
+     *
+     * @var string
+     */
+    const DELIMITER = '#';
 }
diff --git a/src/Interfaces/Port.php b/src/Interfaces/Port.php
@@ -26,6 +26,13 @@
  */
 interface Port extends Component
 {
+    /**
+     * URI component delimiter.
+     *
+     * @var string
+     */
+    const DELIMITER = ':';
+
     /**
      * Maximum port number.
      *

diff --git a/src/Interfaces/Query.php b/src/Interfaces/Query.php
@@ -26,6 +26,13 @@
  */
 interface Query extends Collection, Component
 {
+    /**
+     * URI component delimiter.
+     *
+     * @var string
+     */
+    const DELIMITER = '?';
+
     /**
      * Retrieves a single query parameter.
      *

diff --git a/src/Interfaces/Scheme.php b/src/Interfaces/Scheme.php
@@ -26,4 +26,10 @@
  */
 interface Scheme extends Component
 {
+    /**
+     * URI component delimiter.
+     *
+     * @var string
+     */
+    const DELIMITER = ':';
 }
diff --git a/src/Interfaces/UserInfo.php b/src/Interfaces/UserInfo.php
@@ -21,6 +21,20 @@
  */
 interface UserInfo extends UriPart
 {
+    /**
+     * URI component delimiter.
+     *
+     * @var string
+     */
+    const DELIMITER = '@';
+
+    /**
+     * URI component separator.
+     *
+     * @var string
+     */
+    const SEPARATOR = ':';
+
     /**
      * Retrieve the user component of the URI User Info part
      *