Skip to content
This repository has been archived by the owner on Mar 28, 2021. It is now read-only.

remove deprecated file #20

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Open

remove deprecated file #20

wants to merge 2 commits into from

Conversation

nyamsprod
Copy link
Member

@nyamsprod nyamsprod commented Apr 12, 2020

resolve issue #19

This should make the package composer 2.0 ready @rulatir could you confirm that this is the expected behavior

@nyamsprod nyamsprod added the bug label Apr 12, 2020
@nyamsprod nyamsprod self-assigned this Apr 12, 2020
@galvani
Copy link

galvani commented May 26, 2020

@nyamsprod Is this going to be merged?

@nyamsprod
Copy link
Member Author

nyamsprod commented May 26, 2020

@galvani

First and foremost This PR is for an unsupported version so since I am still waiting for the OP to confirm that the changes do work nothing will be merged and honestly the more I wait and still have no answer the less this PR is likely to get merged. This is an open source project and I'm only working on it when I have time.

So yes it might get merged once everything has been green-lighted and when I have the time to do so.

I would suggest that a better way to approach this would be to help OP in testing yourself if the changes work as expected with composer 2.0 or an even better solution would be to use the latest URI package which exposes the same API and is actively maintained and has no issue with composer v2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants