Use PSR-12 instead of PSR-2 #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this can be merged now. |
|
friendly ping |
gmponos
commented
Jun 19, 2020
| @@ -7,7 +7,7 @@ We accept contributions via Pull Requests on [Github](https://github.com/:vendor | |||
|
|
|||
| ## Pull Requests | |||
|
|
|||
| - **[PSR-2 Coding Standard](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md)** - Check the code style with ``$ composer check-style`` and fix it with ``$ composer fix-style``. | |||
| - **[PSR-12 Coding Standard](https://www.php-fig.org/psr/psr-12/)** - Check the code style with ``$ composer check-style`` and fix it with ``$ composer fix-style``. | |||
There was a problem hiding this comment.
Due to the changes happening to the dev community (master/main branches) I updated this to point to the website instead.
(friendly ping again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I am not 100% that codesniffer fully supports PSR-12. There is an ongoing discussion here:
squizlabs/PHP_CodeSniffer#750
And also I am not sure about styleci.