Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 7 #327

Open
wants to merge 3 commits into
base: 6.x
Choose a base branch
from
Open

Drop support for PHP 7 #327

wants to merge 3 commits into from

Conversation

sneakyvv
Copy link

@sneakyvv sneakyvv commented Jan 5, 2023

Problem

As #321 showed, there's an issue to upgrade the psr/simple-cache package since it changed its PHP constraint to >=8.0.0, and therefore this package's implementation of the CacheInterface in FileCache is no longer compatible with psr/simple-cache because it's using the new mixed type.

Solution

Drop support for PHP7. It's EOL since end of 11/2022, so now is the time to let it go.

NOTE

  • This is of course a BC break, so that's why I'm targeting 6.x, but it seems to be behind on 5.x.
  • Most changes in this PR have been made by running Rector (and verifying them)

Bart Vanderstukken added 2 commits January 5, 2023 12:57
Adjust code to new standards
Was wrongly annotated before
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant