Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated errors in tests #575

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Fix deprecated errors in tests #575

merged 4 commits into from
Feb 14, 2025

Conversation

KorvinSzanto
Copy link
Contributor

This PR fixes deprecated errors and resolved #574 by:

  1. Updating typed arguments that have = null but don't have a nullable type
  2. Allowing newer versions of Pagerfanta in dev dependencies.
  3. Switching from Zend to Laminas in tests, which is fully compatible. In doing so I also duplicated the Zend paginator adapter for use with Laminas

This PR builds on the changes from #572

@KorvinSzanto KorvinSzanto mentioned this pull request Feb 14, 2025
Closed
@KorvinSzanto KorvinSzanto merged commit 573ca2e into master Feb 14, 2025
16 checks passed
@Murazaki
Copy link

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.4 Deprecated messages
2 participants
@KorvinSzanto @Murazaki