fix(output): package

thepercival · Apr 25, 2024 · 31601f7 · 31601f7
1 parent 291bb4d
commit 31601f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/domain/Game/Assigner.php b/domain/Game/Assigner.php
@@ -23,7 +23,7 @@ public function __construct(protected LoggerInterface $logger)
         $this->throwOnTimeout = true;
     }
 
-    public function assignGames(Planning $planning): void
+    public function assignGames(Planning $planning): bool
     {
         $games = (new PreAssignSorter())->getGames($planning);
         // (new GameOutput($this->logger))->outputGames($games);
@@ -46,7 +46,7 @@ public function assignGames(Planning $planning): void
             } else {
                 $planning->setTimeoutState(null);
             }
-            return;
+            return false;
         }
 
         $firstBatch = $planning->createFirstBatch();
@@ -68,12 +68,13 @@ public function assignGames(Planning $planning): void
                     $planning->setTimeoutState(null);
                 }
                 $this->logger->error('   could not assign refereeplaces (plId:' . (string)$planning->getId() . ')');
-                return;
+                return false;
             }
         }
         $planning->setState(PlanningState::Succeeded);
         $planning->setTimeoutState(null);
         $planning->setNrOfBatches($firstBatch->getLeaf()->getNumber());
+        return true;
     }
 
     public function disableThrowOnTimeout(): void

diff --git a/tests/helpers/PlanningCreator.php b/tests/helpers/PlanningCreator.php
@@ -175,9 +175,7 @@ protected function createPlanning(
         if ($showHighestCompletedBatchNr) {
             $gameAssigner->showHighestCompletedBatchNr();
         }
-        $gameAssigner->assignGames($planning);
-
-        if (PlanningState::Succeeded !== $planning->getState()) {
+        if( $gameAssigner->assignGames($planning) === false ) {
             throw new Exception("planning could not be created", E_ERROR);
         }
         return $planning;