Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/python3.8 #14

Merged
merged 2 commits into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions .github/workflows/rspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,6 @@ name: cftest
on: [push, pull_request]

jobs:
test:
name: test
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- name: set up ruby 2.7
uses: actions/setup-ruby@v1
with:
ruby-version: 2.7.x
- name: install gems
run: gem install cfhighlander rspec
- name: set cfndsl spec
run: cfndsl -u
- name: cftest
run: rspec
env:
AWS_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_REGION: ap-southeast-2
rspec:
uses: theonestack/shared-workflows/.github/workflows/rspec.yaml@main
secrets: inherit
4 changes: 2 additions & 2 deletions sftp.config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ apigateway_identity_provider:
named: true
code: identity_provider/index.py
handler: index.handler
runtime: python3.7
runtime: python3.8
timeout: 30
role: SftpIdentityProvider
log_retention: 90
Expand Down Expand Up @@ -80,7 +80,7 @@ output_vpc_endpoint_ips_custom_resource:
log_retention: 14
code: vpc_endpoint_ips/index.py
handler: index.handler
runtime: python3.7
runtime: python3.8
timeout: 60
role: GetVpcEndpointIPs

Expand Down
2 changes: 1 addition & 1 deletion spec/dynamic_users_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@
end

it "to have property Runtime" do
expect(resource["Properties"]["Runtime"]).to eq("python3.7")
expect(resource["Properties"]["Runtime"]).to eq("python3.8")
end

it "to have property Timeout" do
Expand Down
2 changes: 1 addition & 1 deletion spec/identity_provider_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@
end

it "to have property Runtime" do
expect(resource["Properties"]["Runtime"]).to eq("python3.7")
expect(resource["Properties"]["Runtime"]).to eq("python3.8")
end

it "to have property Timeout" do
Expand Down
2 changes: 1 addition & 1 deletion spec/vpc_endpoint_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@
end

it "to have property Runtime" do
expect(resource["Properties"]["Runtime"]).to eq("python3.7")
expect(resource["Properties"]["Runtime"]).to eq("python3.8")
end

it "to have property Timeout" do
Expand Down