Merge pull request #14 from theonestack/feature/python3.8

Feature/python3.8
theonestack · Oct 26, 2023 · e4715cb · e4715cb
2 parents 974a731 + 1083361
commit e4715cb
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 25 deletions.
diff --git a/.github/workflows/rspec.yaml b/.github/workflows/rspec.yaml
@@ -3,23 +3,6 @@ name: cftest
 on: [push, pull_request]
 
 jobs:
-  test:
-    name: test
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v2
-    - name: set up ruby 2.7
-      uses: actions/setup-ruby@v1
-      with:
-        ruby-version: 2.7.x
-    - name: install gems
-      run: gem install cfhighlander rspec 
-    - name: set cfndsl spec
-      run: cfndsl -u
-    - name: cftest
-      run: rspec
-      env:
-        AWS_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY }}
-        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-        AWS_REGION: ap-southeast-2
+  rspec:
+    uses: theonestack/shared-workflows/.github/workflows/rspec.yaml@main
+    secrets: inherit
diff --git a/sftp.config.yaml b/sftp.config.yaml
@@ -49,7 +49,7 @@ apigateway_identity_provider:
       named: true
       code: identity_provider/index.py
       handler: index.handler
-      runtime: python3.7
+      runtime: python3.8
       timeout: 30
       role: SftpIdentityProvider
       log_retention: 90
@@ -80,7 +80,7 @@ output_vpc_endpoint_ips_custom_resource:
       log_retention: 14
       code: vpc_endpoint_ips/index.py
       handler: index.handler
-      runtime: python3.7
+      runtime: python3.8
       timeout: 60
       role: GetVpcEndpointIPs
 

diff --git a/spec/dynamic_users_spec.rb b/spec/dynamic_users_spec.rb
@@ -561,7 +561,7 @@
       end
 
       it "to have property Runtime" do
-          expect(resource["Properties"]["Runtime"]).to eq("python3.7")
+          expect(resource["Properties"]["Runtime"]).to eq("python3.8")
       end
 
       it "to have property Timeout" do

diff --git a/spec/identity_provider_spec.rb b/spec/identity_provider_spec.rb
@@ -556,7 +556,7 @@
       end
 
       it "to have property Runtime" do
-          expect(resource["Properties"]["Runtime"]).to eq("python3.7")
+          expect(resource["Properties"]["Runtime"]).to eq("python3.8")
       end
 
       it "to have property Timeout" do

diff --git a/spec/vpc_endpoint_spec.rb b/spec/vpc_endpoint_spec.rb
@@ -216,7 +216,7 @@
       end
 
       it "to have property Runtime" do
-          expect(resource["Properties"]["Runtime"]).to eq("python3.7")
+          expect(resource["Properties"]["Runtime"]).to eq("python3.8")
       end
 
       it "to have property Timeout" do