Feature/add tests (#18)

* Add default 0 for max cluster roles * Add github action for tests
theonestack · Feb 25, 2024 · 9c2044c · 9c2044c
1 parent c767482
commit 9c2044c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.github/workflows/rspec.yaml b/.github/workflows/rspec.yaml
@@ -0,0 +1,8 @@
+name: cftest
+
+on: [push, pull_request]
+
+jobs:
+  rspec:
+    uses: theonestack/shared-workflows/.github/workflows/rspec.yaml@main
+    secrets: inherit
diff --git a/eks-cluster.cfndsl.rb b/eks-cluster.cfndsl.rb
@@ -278,7 +278,9 @@
     Type node_type
   }
 
-  external_parameters[:max_cluster_roles].times do | cluster_role|
+
+  max_cluster_roles = external_parameters.fetch(:max_cluster_roles, 0)
+  max_cluster_roles.times do | cluster_role|
 
   # cluster_admin_role_arns.split(",").each_with_index do |cluster_admin_arn, index|
     EKS_AccessEntry("AccessEntryAdmin#{cluster_role}") {