Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allows for inlining components with unsafe cfn names #75

Merged
merged 2 commits into from
Nov 14, 2018
Merged

allows for inlining components with unsafe cfn names #75

merged 2 commits into from
Nov 14, 2018

Conversation

aaronwalker
Copy link
Member

No description provided.

@aaronwalker
Copy link
Member Author

Fix for #74

toshke
toshke approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@toshke toshke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch :) not sure I understand why cfndsl broke event with cfndsl -u in build script though.

@aaronwalker
Copy link
Member Author

@toshke was a change in the specification and a bug in cfndsl, which is why I had to update the cfndsl gem version.

@aaronwalker aaronwalker merged commit fd8c18b into theonestack:develop Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toshke toshke toshke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronwalker @toshke