Added ability to change loggroup / function (resource) name for Lambdas #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guslington
requested changes
Oct 1, 2021
| @@ -103,7 +110,11 @@ def render_lambda_functions(cfndsl, lambdas, lambda_metadata, distribution) | |||
|
|
|||
| if lambda_config.has_key?('log_retention') | |||
| Logs_LogGroup("#{name}LogGroup") do | |||
| LogGroupName "/aws/lambda/#{name}" | |||
| if lambda_config['loggroup_name'].nil? | |||
| LogGroupName "/aws/lambda/#{name}" | |||
There was a problem hiding this comment.
providing the ability to set the log group name could lead to confusion as the log group name has to match the function name.
i think this should change to something like
LogGroupName FnSub("/aws/lambda/${#{function_name}}")
|
@Guslington whats the current state of the PR. I'd like to see it merged as it solves a problem deploying a custom log group for the same stack deployed multiple times in the same account |
|
@aaronwalker I don't think the PR quite solves the issue and needs some work as there are 3 different ways to name a lambda which creates situations where using a combinations of these can cause the log group to have a different name to the lambda function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.