-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to change loggroup / function (resource) name for Lambdas #179
base: develop
Are you sure you want to change the base?
Conversation
@@ -103,7 +110,11 @@ def render_lambda_functions(cfndsl, lambdas, lambda_metadata, distribution) | |||
|
|||
if lambda_config.has_key?('log_retention') | |||
Logs_LogGroup("#{name}LogGroup") do | |||
LogGroupName "/aws/lambda/#{name}" | |||
if lambda_config['loggroup_name'].nil? | |||
LogGroupName "/aws/lambda/#{name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
providing the ability to set the log group name could lead to confusion as the log group name has to match the function name.
i think this should change to something like
LogGroupName FnSub("/aws/lambda/${#{function_name}}")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the below commit :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it will be implemented?
@Guslington whats the current state of the PR. I'd like to see it merged as it solves a problem deploying a custom log group for the same stack deployed multiple times in the same account |
@aaronwalker I don't think the PR quite solves the issue and needs some work as there are 3 different ways to name a lambda which creates situations where using a combinations of these can cause the log group to have a different name to the lambda function. |
No description provided.