Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render event when timeslotsPerHour is 1 #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nbenitez
Copy link

Hi, I found a bug when implementig week calendar for my site, that is,
an event renders two lines of text (event time in one line, title in a
second line) and currently the logic is to render each of them on a
timeslot, so you need at least a timeslotsPerHour of 2 so the two
lines look fine, the case is I use a timeslotsPerHour of 1 with enough
height to show the two lines, but week calendar is not doing so.

The fix is for your master branch although I originally made the fix for
1.2.2 version (my project uses jquery 1.3.2).
I made two screenshots of before and after the patch:

Before: http://www.meneame.net/backend/media.php?type=post&id=696616&image.jpg
After: http://www.meneame.net/backend/media.php?type=post&id=696618&image.jpg

I also handle the case someone use one and small timeslotperhour(<26px)
in that case we keep current behaviour and only one line is shown.

I would also take the chance to request you about backporting some
patches to a jquery 1.3.2 branch, there's a lot of people like me that
use jquery-1.3.2 and for a reason (my projects use plugins that dont
have a jquery 1.4 version, and so I cant switch).. and not all patches
but important ones (like the daylight savings one..)

Thank you for an awesome jquery week calendar!

If the slot is big enough (>25px) we show the two lines of text (Event time and title), if not then do current behaviour of only showing one line (event time).
Because of a strange +10 microseconds error over the 
correct value and so comparison fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant