Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hardcoded n_epochs #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove hardcoded n_epochs #23

wants to merge 1 commit into from

Conversation

johnlyzhou
Copy link
Contributor

remove the hardcoded conditional requiring n_epochs==200

remove the hardcoded conditional requiring n_epochs==200
@themattinthehatt
Copy link
Owner

@johnlyzhou good catch here. We'll still need to add some additional updates though - filtering by n_epochs ensures that we only plot the loss values at the end of training; not doing so will plot the loss values for all epochs, which we don't want. So you'll have to find the max number of epochs in the dataframe, then filter by that value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants