Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail repair after additive change in cluster topology #1521

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andresbeckruiz
Copy link

@andresbeckruiz andresbeckruiz commented Sep 3, 2024

This PR fixes (#1367) by failing a repair early if there is an additive change in cluster topology. This PR also adds functionality to optionally reschedule a repair to run after a configurable amount of time.

Fixes #1367

@andresbeckruiz andresbeckruiz force-pushed the fail-repair-after-range-movement branch from 1613410 to 28f33ae Compare November 6, 2024 22:07
@andresbeckruiz
Copy link
Author

I compiled and sucessfully ran all server tests, including five new tests I created in RepairRunnerTopologyChangeTest.java to verify my changes. During testing, I found that manageIncRepairAbovePercentThresholdSchedule in SchedulingManagerTest.java was flaky with and without my code changes, but was able to get the test to pass for both cases.

Screenshot 2024-11-06 at 5 03 54 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repairs Not progressing, when Incremental repairs weren't used and cluster has range movement
1 participant