Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSS nesting #57

Merged
merged 8 commits into from
Sep 29, 2024
Merged

Use CSS nesting #57

merged 8 commits into from
Sep 29, 2024

Conversation

thekid
Copy link
Owner

@thekid thekid commented Feb 25, 2024

This pull request refactors the CSS to use nesting.

Since December 2023, this feature works across the latest devices and major browser versions
Source: https://caniuse.com/css-nesting

Nesting in native or plain CSS is pretty much the same as we saw when using the preprocessor. However, in some browsers and with certain types of selectors, we must begin with the nesting selector, &
Source: https://blog.logrocket.com/native-css-nesting/

@thekid thekid added the enhancement New feature or request label Feb 25, 2024
@thekid
Copy link
Owner Author

thekid commented Feb 25, 2024

Deployed to https://dialog.friebes.info/ for further real-life testing.

Browsers

  • Edge
  • Safari (on iOS)
  • Firefox

Metrics

@thekid
Copy link
Owner Author

thekid commented Feb 25, 2024

Firefox ESR is version 115.8, which doesn't support CSS nesting yet.

receives major updates on average every 42 weeks with minor updates such as crash fixes, security fixes and policy updates as needed, but at least every four weeks.
Source: https://support.mozilla.org/en-US/kb/choosing-firefox-update-channel

@thekid
Copy link
Owner Author

thekid commented May 18, 2024

CSS nesting doesn't require the & for element names anymore, see https://youtu.be/_-6LgEjEyzE?si=d7KUVGjbu4xeQiAZ

image

@thekid
Copy link
Owner Author

thekid commented Sep 29, 2024

Firefox ESR is version 115.8, which doesn't support CSS nesting yet.

Status at the end of September 2024: We are in the transition period between major ESR versions 128 and 115. (Source: https://www.mozilla.org/en-US/firefox/all/desktop-esr/win64-msi/de/)

👉 Think we're good to go now.

@thekid thekid merged commit becc44d into main Sep 29, 2024
13 checks passed
@thekid thekid deleted the refactor/css-nesting branch September 29, 2024 08:37
@thekid
Copy link
Owner Author

thekid commented Sep 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant