This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Fix convert date #220
Open
Fix convert date #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forus
reviewed
Apr 30, 2018
| @@ -164,6 +166,9 @@ class HypercubeJsonSerializer extends HypercubeSerializer { | |||
| writer.nullValue() | |||
| } else if (value instanceof String) { | |||
| writer.value((String) value) | |||
| } else if (value instanceof Timestamp) { | |||
| def time = ((Timestamp)value).toLocalDateTime().atZone(ZoneId.of("GMT")).toInstant().toString() | |||
There was a problem hiding this comment.
@baroleg Thanks for contributing. Would it be possible for you to write a simple regression test that reproduces the issue?
See transmart-core/transmart-rest-api/src/test/groovy/org/transmartproject/rest/serialization/ for test examples.
ewelinagr
force-pushed
the
dev
branch
3 times, most recently
from
93183e7 to
b651751
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rest request
return "startDate": "0000-12-30T00:00:00Z", but in db value is 0001-01-01 00:00:00 (Default value).
Convert as
def time = Instant.ofEpochMilli(((Date) value).time).toString()
is worked for normal date, but for very old date Instant is more strong and convert works wrong.