This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
add hard threshold for GWAS quick search, fix GWAS performance for postgres #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewelinagr
force-pushed
the
dev
branch
3 times, most recently
from
93183e7 to
b651751
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GwasSearchController.groovy added a hard threshold (offset < 500). Reason for this is to be able to display a selection of observations greater than 500 in the GWAS analysis window without resolving to sort on an arbitrary column. For RegionSearchService, we have added SQL queries in postgreSQL, but kept the original Oracle SQL queries. Which queries to be used is conditional on the DB type. Main reason for change is performance when using a PostgreSQL DB.