Binary Clock Settings #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone using the Binary Clock by their bedside will likely prefer a dimmer screen than a person using it at their office desk. To accomodate both preferences, this commit adds a Settings screen with a slider to adjust the clock's brightness. The settings are accessible only via long pressing on the clock face in order to preserve the minimalist feel of the Binary Clock (a Toast is shown on app launch to inform the user of how to access the settings.) Improves #1 Closes #2
For example, the dot worth 32 on the portrait screen will never be used in the hours column, so it should be hidden.
The heirarchy in the SettingsScreen was getting pretty tall, and lots of styles/layout were getting duplicated between the components. This commit creates reusable Boolean/Range Setting components that both look nicer and lay out more nicely.
Binary Clock now has what I consider the minimum viable set of features required for a successful release on the app store! Closes #1
Android devices in dark mode couldn't read the title text on the settings screen. At some future time it would be nice to have full dark mode support, but for now we'll hard code the text to black.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a settings page with the basic customizations required for an MVP version of Binary Clock.
Closes #1
Closes #2
Closes #4