Skip to content

Refs #28961: Disable Crane when Pulp 3 is serving container content #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ehelms wants to merge 1 commit into from
Closed

Refs #28961: Disable Crane when Pulp 3 is serving container content #239

ehelms wants to merge 1 commit into from

Conversation

@ehelms
Copy link
Member

@ehelms ehelms commented Feb 7, 2020

No description provided.

@ehelms ehelms mentioned this pull request Feb 7, 2020
Closed
wbclark
wbclark requested changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I believe it needs:

  1. $proxy_pulp_container_to_pulpcore is documented but never actually declared in init.pp.

  2. Should include pulpcore::plugin::container also depend conditionally on this same parameter?

  3. Tests that the parameter works properly

ekohl
ekohl reviewed Mar 11, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking out loud: Apache will be cleaned up so there's no remaining service. Package removal is generally something we don't do so from that perspective I think this makes sense.

Edit: there's a conflict now.

manifests/init.pp
data_dir => '/var/lib/pulp/published/docker/v2/app',
ssl_protocol => $ssl_protocol,
require => Class['certs::apache'],
if !$proxy_pulp_container_to_pulpcore {
Copy link
Member

@ekohl ekohl Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if !$proxy_pulp_container_to_pulpcore {
unless $proxy_pulp_container_to_pulpcore {

@ehelms
Copy link
Member Author

ehelms commented Jul 9, 2020

Closing in favor of #271

@ehelms ehelms closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekohl ekohl ekohl left review comments

@wbclark wbclark wbclark requested changes

Assignees

No one assigned

Labels

Needs testing Waiting on contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ehelms @ekohl @wbclark @theforeman-bot