Skip to content

Conversation

@rh-max
Copy link
Contributor

@rh-max rh-max commented Mar 10, 2025

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://issues.redhat.com/browse/SAT-24915

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.14/Katello 4.16
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Mar 10, 2025
@github-actions
Copy link

github-actions bot commented Mar 10, 2025

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor suggestions. I can test this after style review is done.

@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Apr 16, 2025
@rh-max rh-max force-pushed the hammer-commands branch from 0e7f9d2 to 3521a3e Compare June 18, 2025 13:14
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Jun 18, 2025
@rh-max
Copy link
Contributor Author

rh-max commented Jun 18, 2025

@maximiliankolb Thank you Max! All feedback implemented. Could you please test this?

Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions.

[id="generating-metadata-and-listing-files-for-syncable-exports"]
= Generating metadata and listing files for syncable exports

When exporting content in a syncable format, metadata and listing files are generated automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When exporting content in a syncable format, metadata and listing files are generated automatically.
When you export content in a syncable format, {Project} generates metadata and listing files automatically.

Avoid passive voice

= Generating metadata and listing files for syncable exports

When exporting content in a syncable format, metadata and listing files are generated automatically.
However, you must manually trigger the generation of these files in the following circumstances:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
However, you must manually trigger the generation of these files in the following circumstances:
Trigger the generation of these files manually under the following circumstances:

Reducing fluff.

Any of the circumstances or all of them at once?

* When using the {Project} API or Ansible modules to do the exports.

.Prerequisites
* The syncable export directory is accessible on disk.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The syncable export directory is accessible on disk.
* You can access the syncable export directory for writing.

Avoid passive voice + clarity

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels Jun 23, 2025
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently fail to reproduce this. Can you please check the commands?

+
[options="nowrap" subs="+quotes"]
----
$ hammer content-export generate-metadata --path=/path/to/syncable/export
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this command on Foreman/Katello 3.14/4.16 but failed:

$ hammer content-export complete repository --organization "Example" --product-id 6 --name "Client" --format=syncable
$ rm -fr /var/lib/pulp/exports/Example/Export-SYNCABLE-Client-40/2.0/2025-06-30T09-04-45-00-00/custom/AlmaLinux_10/Client/repodata/
$ hammer content-export generate-metadata --path=/var/lib/pulp/exports/Example/Export-SYNCABLE-Client-40/2.0/2025-06-30T09-04-45-00-00/
Error: Unrecognised option '--path'.

See: 'hammer content-export generate-metadata --help'.
$ rpm -qa "rubygem-hammer_cli_katello"
rubygem-hammer_cli_katello-1.16.1-1.el9.noarch

Refs SPEC file Hammer CLI plugin for katello

I also checked on Foreman 3.15/Katello 4.17, neither generate-metadata nor generate-listing commands have the --path option.

@aneta-petrova aneta-petrova marked this pull request as draft September 11, 2025 11:58
@aneta-petrova
Copy link
Member

Moving to draft while we look for a new owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing Waiting on contributor Requires an action from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants