-
Notifications
You must be signed in to change notification settings - Fork 107
Add section on generate-metadata and generate-listing commands #3721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The PR preview for 3521a3e is available at theforeman-foreman-documentation-preview-pr-3721.surge.sh The following output files are affected by this PR: |
maximiliankolb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor suggestions. I can test this after style review is done.
guides/common/modules/proc_generating-metadata-and-listing-files-for-syncable-exports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-metadata-and-listing-files-for-syncable-exports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-metadata-and-listing-files-for-syncable-exports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-metadata-and-listing-files-for-syncable-exports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-metadata-and-listing-files-for-syncable-exports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-metadata-and-listing-files-for-syncable-exports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-metadata-and-listing-files-for-syncable-exports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-metadata-and-listing-files-for-syncable-exports.adoc
Outdated
Show resolved
Hide resolved
|
@maximiliankolb Thank you Max! All feedback implemented. Could you please test this? |
Lennonka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions.
| [id="generating-metadata-and-listing-files-for-syncable-exports"] | ||
| = Generating metadata and listing files for syncable exports | ||
|
|
||
| When exporting content in a syncable format, metadata and listing files are generated automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| When exporting content in a syncable format, metadata and listing files are generated automatically. | |
| When you export content in a syncable format, {Project} generates metadata and listing files automatically. |
Avoid passive voice
| = Generating metadata and listing files for syncable exports | ||
|
|
||
| When exporting content in a syncable format, metadata and listing files are generated automatically. | ||
| However, you must manually trigger the generation of these files in the following circumstances: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| However, you must manually trigger the generation of these files in the following circumstances: | |
| Trigger the generation of these files manually under the following circumstances: |
Reducing fluff.
Any of the circumstances or all of them at once?
| * When using the {Project} API or Ansible modules to do the exports. | ||
|
|
||
| .Prerequisites | ||
| * The syncable export directory is accessible on disk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * The syncable export directory is accessible on disk. | |
| * You can access the syncable export directory for writing. |
Avoid passive voice + clarity
maximiliankolb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I currently fail to reproduce this. Can you please check the commands?
| + | ||
| [options="nowrap" subs="+quotes"] | ||
| ---- | ||
| $ hammer content-export generate-metadata --path=/path/to/syncable/export |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this command on Foreman/Katello 3.14/4.16 but failed:
$ hammer content-export complete repository --organization "Example" --product-id 6 --name "Client" --format=syncable
$ rm -fr /var/lib/pulp/exports/Example/Export-SYNCABLE-Client-40/2.0/2025-06-30T09-04-45-00-00/custom/AlmaLinux_10/Client/repodata/
$ hammer content-export generate-metadata --path=/var/lib/pulp/exports/Example/Export-SYNCABLE-Client-40/2.0/2025-06-30T09-04-45-00-00/
Error: Unrecognised option '--path'.
See: 'hammer content-export generate-metadata --help'.
$ rpm -qa "rubygem-hammer_cli_katello"
rubygem-hammer_cli_katello-1.16.1-1.el9.noarch
Refs SPEC file Hammer CLI plugin for katello
I also checked on Foreman 3.15/Katello 4.17, neither generate-metadata nor generate-listing commands have the --path option.
|
Moving to draft while we look for a new owner. |
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://issues.redhat.com/browse/SAT-24915
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: