refactor: remove acl dynamic #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: job result end loop * wip * events can be created * improvementes * fix: missing deps * fix: middlewares function params * remove commented code * missing req object * fix(event): controller.fetch using fetchBy api * feat: fetch and create events * fixes * fix: event payload must be array * fix identation
* feat: indicator can trigger custom event by props * fix: event query
* captura and handle errors * search event emitter by ALL possible event names * fix: file capture errors * arg handling
* local script * fix: job status
facugon
force-pushed
the
development
branch
2 times, most recently
from
1fa31e1 to
fab6e2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this property was used only once in a complex approval workflow.
the new way of doing this is using the "empty_viewers" property . this setting empty the acl of "viewers" before creating the job and hiding the execution to them.
neither the user interface nor the api supported it anymore. there is no way to set it but via DB.
we are no longer using this in new implementations.
before updating this code a migration data migration is needed.