-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for clicks #5
Open
Pokesi
wants to merge
6
commits into
master
Choose a base branch
from
tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4ae2c76
Add tests for clicks
Pokesi 8708f3c
fix linter errors
Pokesi 349cc87
fix eslint warnings
Pokesi 5775c5c
im going to kill myself if this doesnt pass the ci
Pokesi f8734e5
PLEASE
Pokesi 18d76ee
remove the button type
Pokesi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,61 @@ | ||
import React from "react"; | ||
import { render, screen } from "@testing-library/react"; | ||
import App from "./App"; | ||
import { act } from "react-dom/test-utils"; | ||
|
||
test("Renders", () => { | ||
render(<App />); | ||
const linkElement = screen.getAllByText(/None/i); | ||
expect(linkElement[0]).toBeInTheDocument(); | ||
}); | ||
|
||
test("Clicking on an option changes the displayed piece", () => { | ||
// const { container } = render(<App />); | ||
render(<App />); | ||
|
||
const radio = screen.getAllByRole("radio"); | ||
|
||
act(() => { | ||
radio[0].click(); | ||
}); | ||
let pieceDisplay = screen.getByRole("none"); | ||
let style = getComputedStyle(pieceDisplay).backgroundColor; | ||
|
||
expect(style).toEqual("yellow"); | ||
|
||
act(() => { | ||
radio[1].click(); | ||
}); | ||
pieceDisplay = screen.getByRole("none"); | ||
style = getComputedStyle(pieceDisplay).backgroundColor; | ||
expect(style).toEqual("violet"); | ||
|
||
act(() => { | ||
radio[2].click(); | ||
}); | ||
pieceDisplay = screen.getByRole("none"); | ||
style = getComputedStyle(pieceDisplay).backgroundColor; | ||
expect(style).toEqual("grey"); | ||
}); | ||
|
||
test("Clicking on a node should change it", () => { | ||
render(<App />); | ||
|
||
const table = screen.getAllByRole("button"); | ||
|
||
for (let i = 0; i < table.length; i++) { | ||
const item = table[i]; | ||
|
||
let style = getComputedStyle(item).backgroundColor; | ||
|
||
expect(style).toEqual("red"); | ||
|
||
act(() => { | ||
item.click(); | ||
}); | ||
|
||
style = getComputedStyle(item).backgroundColor; | ||
|
||
expect(style).toEqual("green"); | ||
} | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't
none
the default role for a<div>
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint complained about it - but maybe i had something there before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tests dont passif the role isnt defined as
none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we shouldn't be setting the ARIA role to
none
anyway. It sounds like your tests are abusing the ARIA role to select this element. Maybe find a different selector? You have a class name on this after all...