Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require safe ^1.2 #51

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Require safe ^1.2 #51

merged 1 commit into from
Feb 11, 2025

Conversation

shish
Copy link
Collaborator

@shish shish commented Feb 11, 2025

1.0 and 1.1 use resource as a literal type hint, which is interpreted as a class name, which results in error reports

(I'm not sure why anybody would be using safe v1.0 or v1.1, but our test suite checks with --prefer-lowest, and I'm not sure why that didn't catch this issue earlier)

1.0 and 1.1 use `resource` as a literal type hint, which is interpreted as a class name, which results in error reports

(I'm not sure why anybody would be using safe v1.0 or v1.1, but our test suite checks with `--prefer-lowest`, and I'm not sure why that didn't catch this issue earlier)
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.74%. Comparing base (489a040) to head (b56a54a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #51   +/-   ##
=========================================
  Coverage     57.74%   57.74%           
  Complexity       53       53           
=========================================
  Files             9        9           
  Lines           142      142           
=========================================
  Hits             82       82           
  Misses           60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shish shish merged commit 92e26fe into master Feb 11, 2025
5 checks passed
@shish shish deleted the pr51 branch February 11, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants