patch: drop DoctrineAnnotations #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BC: AnnotationReader constructor changed and it's methods stops triggering exceptions TestControllerWithInvalidParameterAnnotation deleted as `for` is ignored when `HideParameter` used as parameter attribute Also attribute exceptions and classes polished Fixes: thecodingmachine#675
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #677 +/- ##
============================================
- Coverage 95.72% 95.31% -0.41%
- Complexity 1773 1809 +36
============================================
Files 154 171 +17
Lines 4586 4783 +197
============================================
+ Hits 4390 4559 +169
- Misses 196 224 +28 ☔ View full report in Codecov by Sentry. |
Currently, each parameter attribute is assigned to method's parameter instead of method, makes this check useless
oojacoboo
requested changes
Apr 8, 2024
|
@oojacoboo I marked this PR as draft because I though it would be nice to fix documentation with it (and remove php7 examples as we do not support it). Or I can have make that in separate PR. What is better for you? |
Agreed. Let's update the docs in this PR. |
oojacoboo
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BC: AnnotationReader constructor changed and it's methods stops triggering exceptions
TestControllerWithInvalidParameterAnnotation deleted as
foris ignored whenHideParameterused as parameter attributeAlso attribute exceptions and classes polished
Fixes: #675