Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r3f: Add view control gizmo #87

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

r3f: Add view control gizmo #87

wants to merge 14 commits into from

Conversation

AndrewPrifer
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Feb 24, 2022

THE-101 A View control gizmo

image.png

  • Back/Front/Top/Bottom/Left/Right shortcuts (isomorphic)

@AndrewPrifer AndrewPrifer marked this pull request as ready for review March 2, 2022 15:10
@AndrewPrifer AndrewPrifer requested a review from AriaMinaei March 2, 2022 15:10
@AriaMinaei AriaMinaei force-pushed the feature/the-101-a-view-control-gizmo branch from 164a91d to d21562b Compare March 2, 2022 22:14
@AriaMinaei
Copy link
Member

The gizmo seems to get occluded by some objects. This is reproducible in the shared/r3f-rocket playground.

Screenflick.Movie.62.mp4

AriaMinaei
AriaMinaei requested changes Mar 2, 2022
View reviewed changes
Copy link
Member

@AriaMinaei AriaMinaei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge apart from that one bug I mentioned in a comment. Great work!

(Heads up: I rebased the branch)

@AriaMinaei
Copy link
Member

Just came across this bug: The shift or alt modifier keys apparently can linger for a while. Might be a timeout issue.

Screenflick.Movie.64.mp4

@vezwork vezwork added the awaiting contributor Contributor needs to make action on this PR label Jun 10, 2022
@colelawrence colelawrence changed the title Add view control gizmo r3f: Add view control gizmo Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AriaMinaei AriaMinaei AriaMinaei requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
awaiting contributor Contributor needs to make action on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewPrifer @AriaMinaei @vezwork