Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add control indicators for Compounds in SequenceEditor #233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

colelawrence
Copy link
Contributor

@colelawrence colelawrence commented Jun 24, 2022

Internally written up at Add compound keyframe addition via sequence editor (add keyframe cursors to compound sheet row)

image

Cole.s.screen.capture.of.Playground.Theatre.js.2022-06-24.at.10.48.02.mp4

@vercel
Copy link

vercel bot commented Jun 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
theatre-playground ✅ Ready (Inspect) Visit Preview Jul 8, 2022 at 7:50PM (UTC)

@colelawrence colelawrence force-pushed the feature/2022-06/add-aggregate-cursor-nav-in-sequence-editor branch from fb63b0e to 267dc71 Compare June 24, 2022 15:09
@colelawrence colelawrence requested review from AriaMinaei and vezwork and removed request for AriaMinaei June 24, 2022 15:09
Copy link
Contributor

@vezwork vezwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Product-wise I think its decent enough to merge and come back to. Its slightly strange that the buttons are to the left of the name as opposed to to the right on the leaf props, but it maintains the visual hierarchy which I like. Would defer comments/further changes to others trying it out once its merged tho.

@colelawrence colelawrence requested a review from AriaMinaei June 25, 2022 13:15
@colelawrence
Copy link
Contributor Author

colelawrence commented Jun 25, 2022

Added @AriaMinaei to review to verify that it's okay to start with the UI shown in screenshot.
The other caveat is that the aggregate control is not shown at the whole SheetObject row level.

@colelawrence
Copy link
Contributor Author

Now waiting on design to confirm what to do with right aligning styles from Mariusz

image

@colelawrence colelawrence force-pushed the feature/2022-06/add-aggregate-cursor-nav-in-sequence-editor branch from dab8e65 to 5f8887e Compare July 8, 2022 19:48
@AriaMinaei AriaMinaei added this to the 0.5.1 milestone Jul 12, 2022
@vezwork vezwork added the next release PRs that we want to merge ASAP (but possibly after the current release so we don't add instability) label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release PRs that we want to merge ASAP (but possibly after the current release so we don't add instability)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants