Skip to content

Support aeson-2.0 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support aeson-2.0 #121

wants to merge 1 commit into from

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Jun 11, 2022

fixes #120.

Following the advice in haskell/aeson#881 (comment).

It compiles, did not do any more checks.

nomeata added a commit to nomeata/kaleidogen that referenced this pull request Jun 11, 2022
@nomeata
Patch aws-lambda-haskell-runtime
336e802 
by pulling in theam/aws-lambda-haskell-runtime#121
@nomeata
Copy link
Contributor Author

nomeata commented Jun 13, 2022

Does this need to be backward compatible?

@maerten
Copy link

maerten commented Sep 13, 2022

This PR fixes the issue for me 👍
using stack ; ghc9.2.4 ; stackage nightly-2022-09-12

@NickSeagull
Copy link
Contributor

Was about to merge+publish this, but between this one and #122 , which one should we use?

nomeata
nomeata commented Oct 3, 2022
View reviewed changes
Copy link
Contributor Author

@nomeata nomeata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardly any difference. Maybe takes my code (including the cabal file refinement), but merge in the stack-related changes?

@nomeata
Copy link
Contributor Author

nomeata commented Oct 3, 2022

Or is the .cabal file autogenerated in thus repo? (Haven't worked with package.yaml yet) In that case my change is a bit futile, is it?

@seanhess
Copy link

I'm jumping in to make some changes to an old project and hitting this issue. Any idea when this might be released? How can I help?

@NickSeagull
Copy link
Contributor

Working on merging this, thanks for being patient with the long delays 😅

@NickSeagull NickSeagull mentioned this pull request Feb 6, 2023
Merged
@NickSeagull
Copy link
Contributor

Thanks for this, I've opened a PR with this PR's contents in order to add some CICD checks too. #124.

Closing this one in order to merge the other one

@NickSeagull NickSeagull closed this Feb 6, 2023
@NickSeagull
Copy link
Contributor

Just so you know 1.4.2 has been published with Aeson 2.0 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickSeagull NickSeagull NickSeagull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support aeson-2.0
4 participants
@nomeata @maerten @NickSeagull @seanhess