-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not cache share links #757
Conversation
Signed-off-by: Melroy van den Berg <[email protected]>
✅ Deploy Preview for ananke-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
False. There is a bug in the logic of the partial, that is true. But we CAN and will cache those links. A share link must be cacheable for a specific page. Check the $options dict. |
Something along the lines of this, not tested yet: |
Signed-off-by: Patrick Kollitsch <[email protected]>
I am going to merge this now. I opened an issue for going to look at caching after the release. |
Signed-off-by: Patrick Kollitsch <[email protected]>
You can't just cache the share links, that will result into every blog post having the same URL.
Just use
partial
on the getShareLink.html. So now each post will show the correct URL to share the post via social media or alike.