Skip to content

Commit

Permalink
Fix settings layout
Browse files Browse the repository at this point in the history
  • Loading branch information
vicr123 committed May 16, 2024
1 parent da48c35 commit b853e84
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 12 deletions.
15 changes: 13 additions & 2 deletions application/settings/SingleProfileSettings.qml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ Item {
title: qsTr("Shell")

ColumnLayout {
anchors.left: parent.left
anchors.right: parent.right

Label {
text: qsTr("Set the shell that is used when you start a terminal with this profile")
}
Expand All @@ -87,20 +90,24 @@ Item {
title: qsTr("Text")

GridLayout {
anchors.left: parent.left
anchors.right: parent.right
columns: 3

Label {
Layout.fillWidth: true
text: qsTr("Font")
}

ComboBox {
id: fontBox
Layout.fillWidth: true

model: fontModel
textRole: "family"
valueRole: "family"

implicitWidth: 300

onActivated: () => {
profile.fontFamily = fontBox.currentValue;
profile.saveProfile();
Expand Down Expand Up @@ -131,20 +138,24 @@ Item {
title: qsTr("Colours")

GridLayout {
anchors.left: parent.left
anchors.right: parent.right
columns: 2

Label {
Layout.fillWidth: true
text: qsTr("Theme")
}

ComboBox {
id: colorsBox
Layout.fillWidth: true

model: colorModel
textRole: "description"
valueRole: "identifier"

implicitWidth: 250

onActivated: () => {
profile.colorName = colorsBox.currentValue;
profile.saveProfile();
Expand Down
20 changes: 10 additions & 10 deletions application/translations/en_US.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,32 +182,32 @@
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../settings/SingleProfileSettings.qml" line="68"/>
<location filename="../../../build-theterminal-Desktop_ARM-Debug/application/com/vicr123/theterminal/settings/SingleProfileSettings.qml" line="68"/>
<location filename="../settings/SingleProfileSettings.qml" line="71"/>
<location filename="../../../build-theterminal-Desktop_ARM-Debug/application/com/vicr123/theterminal/settings/SingleProfileSettings.qml" line="71"/>
<source>Set the shell that is used when you start a terminal with this profile</source>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../settings/SingleProfileSettings.qml" line="87"/>
<location filename="../../../build-theterminal-Desktop_ARM-Debug/application/com/vicr123/theterminal/settings/SingleProfileSettings.qml" line="87"/>
<location filename="../settings/SingleProfileSettings.qml" line="90"/>
<location filename="../../../build-theterminal-Desktop_ARM-Debug/application/com/vicr123/theterminal/settings/SingleProfileSettings.qml" line="90"/>
<source>Text</source>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../settings/SingleProfileSettings.qml" line="93"/>
<location filename="../../../build-theterminal-Desktop_ARM-Debug/application/com/vicr123/theterminal/settings/SingleProfileSettings.qml" line="93"/>
<location filename="../settings/SingleProfileSettings.qml" line="99"/>
<location filename="../../../build-theterminal-Desktop_ARM-Debug/application/com/vicr123/theterminal/settings/SingleProfileSettings.qml" line="99"/>
<source>Font</source>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../settings/SingleProfileSettings.qml" line="131"/>
<location filename="../../../build-theterminal-Desktop_ARM-Debug/application/com/vicr123/theterminal/settings/SingleProfileSettings.qml" line="131"/>
<location filename="../settings/SingleProfileSettings.qml" line="138"/>
<location filename="../../../build-theterminal-Desktop_ARM-Debug/application/com/vicr123/theterminal/settings/SingleProfileSettings.qml" line="138"/>
<source>Colours</source>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../settings/SingleProfileSettings.qml" line="137"/>
<location filename="../../../build-theterminal-Desktop_ARM-Debug/application/com/vicr123/theterminal/settings/SingleProfileSettings.qml" line="137"/>
<location filename="../settings/SingleProfileSettings.qml" line="147"/>
<location filename="../../../build-theterminal-Desktop_ARM-Debug/application/com/vicr123/theterminal/settings/SingleProfileSettings.qml" line="147"/>
<source>Theme</source>
<translation type="unfinished"></translation>
</message>
Expand Down

0 comments on commit b853e84

Please sign in to comment.