Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a tvb_kernels package #728

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

maedoc
Copy link
Member

@maedoc maedoc commented Sep 3, 2024

This is a WIP to add a computation kernels package, focused on moving known hotspots from TVB's Python code into C. The set of kernels is for the moment purposefully small, covering just the delay-coupling calculation, in order to move through the whole integration, packaging & deploy process prior to achieving broader coverage.

While the kernels package will have wheels on every relevant platform, a basic NumPy fallback implementation will be maintained, with a primary goal of testing correctness.

The PR add a workflow to do standard pip-based build as well as a spack based build in anticipation of ebrains integration, but here's a few things required before a merge:

  • add use of coupling kernels in TVB w/ benchmarks
  • create a pypi project to submit wheels to
  • add ci build wheels for all platforms
  • add a Spack package definition
  • add dep on this package to tvb library (both pip and spack) & test
  • test within Ebrains & TVB Dockerfile builds
  • clean up commit history

@maedoc maedoc self-assigned this Sep 3, 2024
@maedoc
Copy link
Member Author

maedoc commented Sep 3, 2024

actions are being run over on my fork https://github.com/maedoc/tvb-root/actions tho I could push the branch here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant