Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript: improvements #8003

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Javascript: improvements #8003

merged 5 commits into from
Dec 2, 2024

Conversation

enghitalo
Copy link
Contributor

@enghitalo enghitalo commented Nov 29, 2024 •
edited
Loading

  • versions upgrade
  • version manager
  • clusters
  • Content-Length fixes
  • gitignore

@enghitalo enghitalo requested a review from waghanza as a code owner November 29, 2024 14:19
waghanza
waghanza requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to use cluster explicitly, imho, at least no for all javascript frameworks

pm2 make it for you 😛

@waghanza
Copy link
Collaborator

However, your content length bullet point, makes me say that we need to check it (in specs) to ensure all implementations are returning this header

@enghitalo enghitalo requested a review from waghanza December 2, 2024 13:26
@enghitalo enghitalo changed the title Javascript/clusters Javascript: improvements Dec 2, 2024
@enghitalo enghitalo mentioned this pull request Dec 2, 2024
Merged
10 tasks
@waghanza waghanza merged commit 8abedb6 into the-benchmarker:master Dec 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waghanza waghanza waghanza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enghitalo @waghanza