Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala]: Adding Apache Pekko. #7994

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

whiplash
Copy link
Contributor

Akka (backed by Lightbend, who recently changed name and is actually itself now called Akka) changed its licence.
Quickly after that, an open source fork was born under the Apache foundation with the name Pekko.

Pekko is essentially Akka 2.6.

@whiplash whiplash requested a review from waghanza as a code owner November 27, 2024 16:41
name := "server"
scalaVersion := "3.5.2"

val PekkoVersion = "1.1.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val PekkoVersion = "1.1.2"
val PekkoVersion = "[1.1,1.2)"

scalaVersion := "3.5.2"

val PekkoVersion = "1.1.2"
val PekkoHttpVersion = "1.1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val PekkoHttpVersion = "1.1.0"
val PekkoHttpVersion = "[1.1,1.2]"

@@ -0,0 +1,3 @@
framework:
website: pekko.apache.org
version: 1.1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 1.1.0
version: 1.1

scala/pekkohttp/project/build.properties Outdated Show resolved Hide resolved
name := "server"
scalaVersion := "3.5.2"

val PekkoVersion = "1.1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use the same version for PekkoVersion and PekkoHttpVersion ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's not possible => https://pekko.apache.org/docs/pekko-http/current/introduction.html#using-apache-pekko-http

btw, it's the same with Akka and Akka HTTP.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should ping any core contributor for this, it appears not clear in the docs (at least for me), since version of both are pined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust me, I know and have been used Akka. Akka is the actor framework. Later on they built Akka HTTP which is the HTTP framework on-top-of Akka. So Akka HTTP uses Akka so it's quite natural that versions are different.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems weird for me, but maybe not in scala world 😛

@waghanza waghanza merged commit 8cba03e into the-benchmarker:master Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants