-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scala]: Adding Apache Pekko. #7994
Conversation
scala/pekkohttp/build.sbt
Outdated
name := "server" | ||
scalaVersion := "3.5.2" | ||
|
||
val PekkoVersion = "1.1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val PekkoVersion = "1.1.2" | |
val PekkoVersion = "[1.1,1.2)" |
scala/pekkohttp/build.sbt
Outdated
scalaVersion := "3.5.2" | ||
|
||
val PekkoVersion = "1.1.2" | ||
val PekkoHttpVersion = "1.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val PekkoHttpVersion = "1.1.0" | |
val PekkoHttpVersion = "[1.1,1.2]" |
scala/pekkohttp/config.yaml
Outdated
@@ -0,0 +1,3 @@ | |||
framework: | |||
website: pekko.apache.org | |||
version: 1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: 1.1.0 | |
version: 1.1 |
name := "server" | ||
scalaVersion := "3.5.2" | ||
|
||
val PekkoVersion = "1.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you use the same version for PekkoVersion and PekkoHttpVersion ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it's not possible => https://pekko.apache.org/docs/pekko-http/current/introduction.html#using-apache-pekko-http
btw, it's the same with Akka and Akka HTTP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should ping any core contributor for this, it appears not clear in the docs (at least for me), since version of both are pined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trust me, I know and have been used Akka. Akka is the actor framework. Later on they built Akka HTTP which is the HTTP framework on-top-of Akka. So Akka HTTP uses Akka so it's quite natural that versions are different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems weird for me, but maybe not in scala world 😛
Akka (backed by Lightbend, who recently changed name and is actually itself now called Akka) changed its licence.
Quickly after that, an open source fork was born under the Apache foundation with the name Pekko.
Pekko is essentially Akka 2.6.