Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (C#) : use defaults #6800

Merged

Conversation

ShreyasJejurkar
Copy link
Contributor

No description provided.

@waghanza
Copy link
Collaborator

waghanza commented Oct 8, 2023

Why removing tiered pgo, it is the default?

@ShreyasJejurkar
Copy link
Contributor Author

It is not now, but as we decided not to use any custom options in framework so I am removing this.

And also in .NET 8 it will be ON by default at runtime level itself, so anyway we don't need this.

@waghanza
Copy link
Collaborator

waghanza commented Oct 8, 2023

Ok. We will have this option by default in mid-November then

Let's avoid it for the couple of updates until then

@waghanza
Copy link
Collaborator

waghanza commented Oct 8, 2023

Thanks @ShreyasJejurkar. I'm aligned with this. Maybe we should / could have the same operation for all F# frameworks

Wdyt @panesofglass @jchannon?

@waghanza waghanza merged commit 07441e8 into the-benchmarker:master Oct 8, 2023
4 of 5 checks passed
@ShreyasJejurkar
Copy link
Contributor Author

@waghanza I am addressing that next. Could you please create an issue for all of these settings, so that people will update their FW implementation to respect the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants