Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript): add Bunicorn #6779

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

ragokan
Copy link
Contributor

@ragokan ragokan commented Oct 6, 2023

Hello, I wanted to add the new framework that is running on top of Bun. I was not able to test locally because I was not able to run it on Apple Silicon. I know, the framework yet does not have a documentation but I am creating it right now and wanted to see how it performs and see it on https://web-frameworks-benchmark.netlify.app. Thanks!

@ragokan ragokan requested a review from waghanza as a code owner October 6, 2023 14:26
waghanza
waghanza previously approved these changes Oct 6, 2023
Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you succeed 🎉

javascript/bunicorn/config.yaml Outdated Show resolved Hide resolved
Thanks for suggestipn.

Co-authored-by: Marwan Rabbâa <[email protected]>
@ragokan
Copy link
Contributor Author

ragokan commented Oct 6, 2023

Seems you succeed 🎉

When I merge, does it mean that it can be available on website soon? Also, I added your suggestion, thank you!

@ragokan ragokan requested a review from waghanza October 6, 2023 14:39
@waghanza
Copy link
Collaborator

waghanza commented Oct 6, 2023

Results are update every monday (actually with some manual steps since on my workstation, with an arch closed to a cloud server)

@ragokan
Copy link
Contributor Author

ragokan commented Oct 6, 2023

Results are update every monday (actually with some manual steps since on my workstation, with an arch closed to a cloud server)

I understood it, thank you so much for response. Since I updated the code again, I think it needs a new approval.
Have a great day!

@waghanza waghanza merged commit 257f2a7 into the-benchmarker:master Oct 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants