-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency scala to v3.3.1 #6699
Conversation
I wouldn't move out of 3.2 so quickly. Akka http for example does not seem to be compatible at the moment. |
The idea could be to use the latest version of scala, that could be used per framework (ex : use zio in 3.3 and play is 2.3) |
|
What do you may think of that @whiplash ? |
2ee246e
to
522202c
Compare
522202c
to
166ed13
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
5d32297
to
e062948
Compare
@whiplash only play is not working (still in scala2) |
I'm having a look at this https://www.playframework.com/documentation/2.9.x/Highlights29#Scala-3-support |
so it might "work" if you just add it'll look something like
|
cd72b2a
to
2e7ee75
Compare
Reading the implementation, it is not obvious knowing the version we use |
|
it's gotta be one of these https://central.sonatype.com/artifact/com.typesafe.play/sbt-plugin/versions |
@whiplash seems that play could not use scala3 14:13:15.469 [main] INFO play.api.http.HttpErrorHandlerExceptions -- Registering exception handler: guice-provision-exception-handler
WARN application - Logger configuration in conf files is deprecated and has no effect. Use a logback configuration file instead.
INFO play.api.Play - Application started (Prod) (no global state)
Oops, cannot start the server.
java.lang.NoClassDefFoundError: akka/http/scaladsl/ConnectionContext
at play.core.server.AkkaHttpServerProvider.createServer(AkkaHttpServer.scala:742)
at play.core.server.AkkaHttpServerProvider.createServer(AkkaHttpServer.scala:741)
at play.core.server.ServerProvider.createServer(ServerProvider.scala:30)
at play.core.server.ServerProvider.createServer$(ServerProvider.scala:21)
at play.core.server.AkkaHttpServerProvider.createServer(AkkaHttpServer.scala:740)
at play.core.server.ProdServerStart$.start(ProdServerStart.scala:58)
at play.core.server.ProdServerStart$.main(ProdServerStart.scala:28)
at play.core.server.ProdServerStart.main(ProdServerStart.scala)
Caused by: java.lang.ClassNotFoundException: akka.http.scaladsl.ConnectionContext
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525) |
btw, with this config we use play 2.9RC instead of 2.8 as it is displayed |
0cac711
to
514744b
Compare
I might have a fix for Play. Should I open a specific PR? |
Sure @whiplash. Rather to target this branch tho |
@whiplash I try to use latest play version (with minimal changes). could you take a look ? |
This PR contains the following updates:
3.2.2
->3.3.1
Release Notes
lampepfl/dotty (scala)
v3.3.1
Compare Source
Highlights of the release
Other changes and fixes
Backend
Coverage
Default parameters
Documentation
Erasure
@companionClass
and@companionMethod
meta-annotations #17091Extension Methods
GADTs
Implicits
P
in the implicit scope ofP.this.type
#17088Incremental Compilation
Infrastructure
Inline
Java Interop
Linting
-Wnonunit-statement
setting for dotty #16936Match Types
Parser
.
to fall outside previous indentation widths #17056Pattern Matching
@unchecked
and non-unreachable #16958Pickling
Polyfunctions
Quotes
paramProxy
andthisProxy
inQuote
type #17541@SplicedType
quote local refrences #17051Object.toString
forquoted.{Expr, Type}
#16663Reflection
New
/Select
-Ycheck message #16746defn.FunctionClass
overloads #16849REPL
Reporting
Scala-JS
Scaladoc
SemanticDB
Specification
class-shadowing.md
to the Spec #16839Standard Library
Tooling
ExtractSemanticDB
phase when writing to output directory defined as JAR. #16790Transform
Typer
Nothing
andnull
args #16938AnyVal
s as refinement members ofSelectable
s #16286Contributors
Thank you to all the contributors who made this release possible 🎉
According to
git shortlog -sn --no-merges 3.3.0..3.3.1
these are:v3.3.0
Compare Source
Highlights of the release
fewerBraces
a standard feature #16297Other changes and fixes
Annotations
Desugaring
applyDynamic
andapplyDynamicNamed
#16552Erasure
GADTs
Incremental compilation
Initialization
Inline
Java interop
Linting
<init>
instead of its owner (also fix false positive for enum) #16661isValidMemberDef
check #17316Opaque Types
Overloading
Parser
Pattern Matching
Pickling
Polyfunctions
Quotes
spliceOwner
#16513REPL
Reflection
Reporting
Scala-JS
js.native
in native member rhs. #16185Scaladoc
ClassLikeSupport
getParentsAsTreeSymbolTuples #16759Standard Library
CanEqual
instance forMap
#15886Tuple.Append
return type #16140Mirror#fromProductTyped
#16829TASTy format
Tooling
Transform
<init>
methods as package members #16667Typer
MethodHandle
andVarHandle
) #16225@targetName
into account when resolving extension methods #16487Contributors
Thank you to all the contributors who made this release possible 🎉
According to
git shortlog -sn --no-merges 3.2.2..3.3.0
these are:Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.