Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to create teams #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

punchagan
Copy link
Member

No description provided.

This version tries to form gender aware teams, but uses a very crude
algorithm, also handles players with unknown genders.

Co-authored-by: Puneeth Chaganti <[email protected]>
@punchagan
Copy link
Member Author

Sorry for the delay in reviewing this PR. I've cleaned up this PR to add a single commit that adds the initial functionality.

There's still some work left, before I'd be comfortable merging this.

  • I think we should trigger the forming of teams using another API call - users can click a button to create teams. And ideally this would be done after there are a significant number of players willing to participate. Any RSVPs that happen after the formation of teams can be automatically added to a team.
  • I'm not sure how to handle cancellation of RSVPs - if we modify the teams, I think we would like to send a notification to users or something, but this could also be a feature that we add later. We should at least indicate in the UI when an RSVP has been cancelled, even if we don't change the teams. Let humans deal with that, for now.
  • I think we don't want to always form pick-up teams, and may be add a flag on the event to indicate if we should allow forming pickup teams. But, this I guess is optional if we make the forming of pick-up teams be triggered by another API call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants