Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all files under src except test and add eslint for travis ci #43

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

sandhyak-tech
Copy link
Contributor

No description provided.

@sandhyak-tech
Copy link
Contributor Author

#38

@thamaraiselvam
Copy link
Owner

All files showed as got deleted and recreated again, we would lose all existing commit history. so use git mv to move files to src folder it would show as files are renamed.

@sandhyak-tech
Copy link
Contributor Author

i used git mv command .. it still shows the same

@thamaraiselvam
Copy link
Owner

Stage all local changes.

mkdir src
git mv Array src

and you should see this

Screenshot 2021-10-14 at 1 49 51 PM

@sandhyak-tech
Copy link
Contributor Author

Stage all local changes.

mkdir src
git mv Array src

and you should see this

Screenshot 2021-10-14 at 1 49 51 PM

It was due to the Precommit task that was automatically changing it as delete and move .. i disabled the husky task for this push and later on made it live.

@thamaraiselvam
Copy link
Owner

@sandhyak-tech I see, Still it shows as deleted and created new files.

@thamaraiselvam
Copy link
Owner

I have added hactoberfest-accepted label. let me know If you still want to work on this.

@sandhyak-tech
Copy link
Contributor Author

@thamaraiselvam .. That is the revereted commit .. plz check from commit 6bb1423

@thamaraiselvam
Copy link
Owner

Yes, your latest commit is valid but on file changes tab it shows files got deleted and recreated, Wondering what challenges will be merged. It supposed to show latest changes only.

@thamaraiselvam
Copy link
Owner

Let's not spend more time on this. Lets close this PR and you create new PR with required commits. WDYT?

@sandhyak-tech
Copy link
Contributor Author

if this commit is closed.. ill not be eligible for hactoberfest because i have already closed 2 PRs by myself by mistake. Any other possibilities to do this?

@thamaraiselvam
Copy link
Owner

Let it be open. Create a new PR I will close this once PR matured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants